fish-shell/fish-shell — pull request #1633 by kballard (2014-08-22 21:10:57+00:00)
Title: Fix `commandline` behavior in bind functions

When a key is bound to a fish function, if that function invokes
`commandline`, it gets a stale copy of the commandline. This is because
any keys passed to `self-insert` (the default) don't actually get added
to the commandline until a special character is processed, such as the
R_NULL that gets returned after running a binding for a fish command.

To fix this, don't allow fish commands to be run for bindings if we're
processing more than one key. When a key wants to invoke a fish command,
instead we push the invocation sequence back onto the input, followed by
an R_NULL, and return. This causes the input loop to break out and
update the commandline. When it starts up again, it will re-process the
keys and invoke the fish command.

This is primarily an issue with pasting text that includes bound keys in
it. Typed text is slow enough that fish will update the commandline
between each character.

---

I don't know of any way to write a test for this, but the issue can be
reproduced as follows:

> bind _ 'commandline -i _'

This binds _ to a command that inserts _. Typing the following works:

> echo wat_is_it

But if you copy that line and paste it instead of typing it, the end
result looks like

> _echo wat_isit

With this fix in place, the pasted output correctly matches the typed
output.