jtriley/pystun — pull request #8 by abarnert (2014-08-21 18:28:42+00:00)
Title: Python 3.x compat, cleanup

I updated the code to be Python 3-compatible; it should run under any 2.6+/3.2+.

I smoke-tested with 2.6, 2.7, 3.3, and pre-3.5 trunk with CPython, and 2.7 and 3.2 with PyPy 2.3.1.

Rather than try to fix all the mixed-str-and-bytes stuff caused by trying to work with hex strings instead of raw bytes, I changed it to use `struct.pack`/`unpack` everywhere. I believe I caught and fixed at least one bug along the way where a hex string was sent in place of the bytes it represented. But I wouldn't be too surprised if I also added at least one bug. Unfortunately, there doesn't seem to be a test suite, and I'm not sure how to stress-test it myself.

I also cleaned up the code so that it passes PEP8 (no point adding an automated PEP8 test to just ignore the warnings…), and updated `check.py` so that it works with PEP8 1.3 and later.