jonathanmccann/liferay-portal — pull request #404 by arbetts (2014-08-20 17:48:55+00:00)
Title: Lps 47199

I tried to keep the pattern consistent with what was already in the services

for JournalFolderLocalService it appears that the pattern is to call the same finder multiple times with different arguments

for JournalFollderService the pattern looks like we call a different method within the same service in order to alter the parameters

so for the Service changes I made the old service method call the service method that I added and for LocalService changes I made the calls to the finder method with varying args.

I also added javadoc to the service methods I added in JournalArticleServiceImpl because of the explanation of the "ownerId" parameter. In addition to that I did not change the name of the JournalArticleFinder method to include "O" for owner because technically "O" does not exist in the service xml. it is really the userId that we are querying (which is already in the method signature).

All of this could be accomlished by adding new service -> finder -> customSql instead of modifying the existing methods in the finders and modifying the sql in the journal xml, but it would duplicate a lot of the same logic.