blzaugg/liferay-portal — pull request #106 by noellekimiko (2014-08-13 17:30:00+00:00)
Title: LPS-37979 Repeated IDs in Asset Categories Admin

Jira ticket: https://issues.liferay.com/browse/LPS-37979
Original pull request: https://github.com/noellekimiko/liferay-portal/pull/6

* Checked in Chrome, Firefox, IE 8, 9, 10 and 11
* Follows formatting guidelines mostly
* In _createCategoryPanelAdd and _createVocabularyPanelAdd, the parameters for the dialog element (cssClass and destroyOnHide) could be alphabetized, as shown in the last commit (780888711b4a9cdafd1fe19d3d0d89819350bc43)
* No longer need to call .show() for either Vocabulary panel or Category panel since .hide() is no longer called for either (commit: a9bde83e4367dbc4af2fd265b000455d6d9e4e20)
* For the _showVocabularyPanelAdd, the line "instance._focusVocabularyPanelAdd();" was removed
* When it is included in this new version, it causes errors, so it makes sense to remove it
* However, this is the only call to that method. Should it be left in the file? (It is still present in this version.)
* I think it is intended to focus the "name" field of the panel, but that occurs without calling this method
* IE 9: if you edit the name of a category or vocabulary, it won't let you change it back to the original value. No errors, but the name doesn't display as updated
* This problem is also present with the original code, so it is unrelated to this bugfix