gds-operations/vcloud-launcher — pull request #61 by dcarley (2014-08-08 07:46:21+00:00)
Title: Omit fs_file/fs_mntops from tests

The `fs_file` and `fs_mntops` fields for `extra_disks` don't currently
feature in Vcloud::Launcher::Schema::VM which validates our input files.

There was a discussion in gds-operations/vcloud-launcher#5 about whether one
of them should be added, but it dropped to the wayside. My personal feeling
is that site-specific preamble details shouldn't leak back into the main
schema. It might more appropriate to use a hash in boostrap[:vars] which is
keyed against extra_disks[:name].

In the meantime though our examples shouldn't refer to things that aren't in
the schema. So remove these references in tests that just check one thing
has been passed to another thing *after* schema validation has occurred.

This does raise an interesting point though; how do we keep these up to
date as the schema changes? Does it matter?

/cc @bazbremner