buildbot/buildbot — pull request #1192 by jpommerening (2014-08-04 10:16:24+00:00)
Title: Fix timed schedulers (WIP)

Hi!

I'm just (sloooowly) trying out nine and the first thing I noticed is that the timed schedulers stopped working, caused by the changes to the scheduler API (`addBuildsetForLatest` removal, #597).

This probably went unnoticed because the scheduler's unit tests simulate that part of the API to spy on the method calls.

I already "fixed" the tests (update them to use `addBuildsetForSourceStampsWithDefaults`) and replaced some calls in the Nightly- and Periodic- schedulers.

However, the schedulers take a `branch` parameter and used that with `addBuildsetForLatest`. I'm not really sure how to handle that. Looks like it should use a codebase instead, but the details are a bit fuzzy…