OCA/partner-contact — pull request #19 by bwrsandman (2014-08-04 17:23:28+00:00)
Title: Add res_bank_account module

Add res_bank_account module: add the title bank account, observation and active boolean fields.It allows to manage several bank accounts for each contact

Port of https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047

Previous reviews:
---

@yvaucher:

> Description seems inaccurate to me, OpenERP already allows to manage multiple bank account per partner.
>
> What is the plus-value when installing this module?
> I suppose this is to add details on bank accounts to describe for what they should be used.
> Why should I need a title_bank_account and an observation field on my res_partner_bank
> Wouldn't one field be enough?
> If I needed more info on res.partner.bank, I would simply add a 'description' field as on other models
>
> title_bank_account seems useless to me as it isn't even in tree views.
>
> Active field already exists on res.partner.bank model. By the way you overide the select=True parameter on it.
>
> And finally this may be a matter of taste but I would name this module res_partner_bank_imp instead.
>
> Thus sorry but I'll disaprove this one in that state.

Ana Juaristi Olalde:

@yvaucher
> title_bank_account seems useless to me as it isn't even in tree views.
>
> This is a subjective opinion. If someone needs 2 fields, he adds 2 fields. That's all :)
>
> @ehdem
> My oppinion is Need fixing because:
>
> 1.
> If you replace bank_ids with something hardcoded on your module view, you will not see new "future" core improvements on that view.
>
> 2. I agree with @yannick in --> Active field already exists on res.partner.bank model. By the way you overide the select=True parameter on it.

@yvaucher:

> Thanks for the review Ana
>
> My point about title_bank_account is that most of Models have standard `name` and `description` fields.
> I agree having a second field description is quiet useful to add note on the object when you open it.
>
> However as res.partner.bank is already a bank account, naming a field xxx_bank_account seams also redundant. Thus I think it is badly named.
>
> Still, module description doesn't match what the module does. This is more about adding fields for informations than allowing to manage multiple bank accounts. Or am I missing something?