ProjectSWGCore/NGECore2 — pull request #1077 by voronius (2014-08-04 19:31:13+00:00)
Title: 2 Small fixes, one for a query and the other for the inspiration buffs

1.For the first one , clearly the field name is "id" not "Id", this makes possible char reusal and delete if the server is not restarted (?) . This is only half of fix, there's a need for a fix in the engine too.
The main point is :
SWGObject object = (SWGObject) core.getSWGObjectODB().get(objectId);
call from ObjectService.java method getCreatureFromDB(long objectId)
this gets the right input and despite the data existing in the database it returns something that doesn't have proper name fields (CustomName, FirstName, LastName).
2.For the inspiration and group buffs
There's a check that uses 2 different systems of coordinates when the group is inside a cell
(using getWorldPosition for one member and getPosition for the rest) , I just make this use getWorldPosition
for all. This fixes the bug , thereby making buffs possible. A more complicated fix would be needed to avoid things happening accross walls ( or additional checks for line of sight inside the inspiration python scripy), ex. in pseudocode :
if both inside a cell
use getPosition for check for both
else
use getWorldPosition for check for both
...
or just check for line of sight when watching or doing inspire