LIL717/CeaselessIOS — pull request #9 by LIL717 (2014-08-04 07:09:11+00:00)
Title: added loading verse from Bible API, cleaned up iPad storyboard to match ...

First, I just cleaned up the iPad storyboard to match the iPhone storyboard, removed the settings image from the nag bar, removed the checkmarks and added a Settings tab.

The request for the Bible verse is working.
Here are some issues I noticed:
1. some of the verses are too long for the phone, the label they are contained within ends up filling the whole screen. I could add a scroll view underneath the whole view so that you could scroll down to see the people to pray for, but I think it would be better to do one of the following:
a. change something on the server side to limit the size of the verses for the phone
b. add a separate tab for the Bible verse
c. change something on the phone side to truncate longer verses

2. At the moment, retrieving the Bible verse is "delayed" compared to loading the people to pray for. The calls happen in the background (which is where those kind of calls should happen, they shouldn't block the main thread), but its sort of a weird user experience for the Bible verse to pop in at the top of the screen. I think this will work itself out when the friends are also being retrieved from the server rather than being hardcoded.

3. I get a different verse every time I call the API. This isn't a problem for the daily emails, but the phone/ipad app could be opened more than once a day.
Possible fixes:
a. limit the available verse on the server side so that the same verse is retrieved all day long (and matches between the email and the app daily)
b. maybe we don't care if they get a different verse every time they open the app
c. cache the verse on the device and only make the call if the date since the cached verse has changed

4. The spacing is sort of funky for the phone when there is more than one verse. There is a linefeed and 3 tabs before each verse.
Possible fixes:
a. reformat on the phone
b. reformat on the server side
c. maybe it won't matter if we only get short verses :)