theforeman/staypuft — pull request #253 by sseago (2014-08-05 05:39:19+00:00)
Title: field-level validation for equallogic fields

A couple notes:
1) the actual validation requirements are included in comments near the
'validates' entries. These were provided to me as the definitive
rules -- so review here would be to make sure that the regexps, etc.
validate as stated in the comments -- if there is some question around
the validity of the comment itself, we should handle that separately
2) for the SAN IP address, the provided validation enforces it to be
an actual IP address. Apparently, a hostname/fqdn is valid here too,
so this validation needs to be expanded to handle that case. For the moment
I'm not sure if it's better to leave this validation off until it's complete
(if hostname-valued params will be common here), or if restricting it to an
IP addr is fine for now (which would be the case if this is the common case
and using a hostname/fqdn is more of an edge case.