nebulab/spree-subscriptions — pull request #44 by brchristian (2014-08-04 01:09:12+00:00)
Title: Fix shipped?(issue) method

This corrects what appears to have been a bug in the `Subscription.shipped?(issue)` method, where the logic had been:

!shipped_issues.where(:id => issue.id).empty?

which seemed off to me -- the `:id` of a shipped_issue would be the shipped_issue's _own_ id, not the issue_id. So I changed that to

!shipped_issues.where(issue: issue).empty?

which I think is the original intention.

Note that I also suggested changing `!empty?` to `present?` for simplicity:

shipped_issues.where(issue: issue).present?