puppetlabs/puppetlabs-apache — pull request #803 by Spredzy (2014-07-29 22:36:11+00:00)
Title: vhost: Create the $logroot only when necessary.

Currently, there is no way to specify default `$logroot` directory permissions.
It will always take the one from default.

Admitting we specify `apache::default_vhost: false`, this will ensure
`default_vhost_ensure` is set to absent. Then it will call
`apache::vhost { 'default'` with `ensure = absent`.

The problem is that the file resource that defines `$logroot` is surrounded
only by an `if !defined()`, so since when default pass it is not defined - yet,
it is true, it then enters and create the `$logroot` with default permissions.

Even if I specify `apache::default_vhost: false` and specify the `$logroot_mode`
of my custom `apache::vhost`, it will never make it in, since it as already be defined.