SpiritQuaddicted/reQuiem — pull request #41 by neogeographica (2014-07-27 02:46:59+00:00)
Title: always allow binding toggleconsole from menu

Resolves issue #28.

"Reserved keys" are described in more detail in the issue, although actually
there's even more to it than I cover there.

It seems like there is some partially-implemented stuff going on, across a few
different but related features all trying to make the creating and using of
key binds a little smarter. Touching any part of the various "reserved key"
definitions/interpretations is likely to affect multiple behaviors.

Rather than try to untangle the spaghetti I'm going to just deal with this
particular Gordian knot -- pardon the mixed metaphors -- and always allow the
toggleconsole binding from the "Other Controls" menu, regardless of what key
is selected. If you happen to pick a key that you later find to be
inconvenient then OK, just bind it to something better.

The key restrictions don't seem as onerous for the other items in that menu
(like screenshot or quicksave) so I left those alone.