aodn/aodn-portal — pull request #1309 by dnahodil (2014-07-25 01:14:11+00:00)
Title: Tidy up suggestion

@jkburges just wanted your feedback on this.

It removes duplication but uses a function in a way that might be confusing.
ie.

var urlFn = this._getUrlGeneratorFunction();

return {
url: urlFn(collection),
urlFieldName: this._urlFieldName()
};

There might be a different way of declaring the functions so that the scoping works but this usage is clearer?