modxcms/revolution — pull request #11795 by exside (2014-07-23 15:30:06+00:00)
Title: Fix for #11789: User / User Group Settings update and delete fix

Fixes https://github.com/modxcms/revolution/issues/11789

See description in issue above, quite a severe bug if you ask me =)...basically updating a user or user group setting via context menu (directly in grid worked) is updating the system setting and not the user / user group setting, deleting it via context menu deletes a system setting with the same name instead of deleting the user / user group setting. I guess this bug was also present before 2.3, so maybe that should be added to 2.2.x patch releases too...

A question I couldn't answer is, **why it works for context settings**, when I search trough all extjs code, I cannot find one mention of "context/setting/remove" as an action, but deleting a context setting via contextmenu > delete triggers the right processor, can anybody explain why?

Not sure about the way I fixed it (basically overriding the methods from the MODx.grid.SettingsGrid class with the right actions), in the context settings grid it's solved differently (but I don't fully understand, see question above). **Question 2**: Would it be better to extend the setting update window (as it's done in the context settings grid) instead of overriding the methods of the parent class?