dart-lang/chromedeveditor — pull request #2934 by devoncarew (2014-07-22 16:17:29+00:00)
Title: fix the bots

Fix the bots. The issue was this commit:

https://github.com/devoncarew/spark/commit/166836071f77288eac77eaa48c05002039d3d00a

Which for some reason causes dart2js to generate a much larger file for the services layer, which then leads to flaky services tests. Not sure why the larger file or why the flakiness. I suspect that the mirrors use in tavern/pub was now being brought into scope of the services layer compile, which led to the code expansion.

The net-net is that we need to be careful about separating out our services layer code, and being aware of what features we bring into scopre via imports. I think ideally all our services code would live in `services/`, and it would never reference code outside of that dir. From looking a the dart2js compilation digest, some html code, and svg code, is being compiled into the services layer, which is _very_ odd.