twitter/scalding — pull request #968 by johnynek (2014-07-22 02:17:59+00:00)
Title: Make TypedPipe immutable

Let's really look carefully at this. This was an attempt at a minimal change that would be source-code compatible.

Some questions:

1. should TypedPipeInst be a case class? It seems like we don't want to pattern match and get the FlowDef back out, as it should never be mutated. Tend to think it should not be a case class (and we can add a custom unapply if needed to match the old cases, which does not expose the flowDef).
2. Should we bite the bullet and make an ImmutableFlowDef, which is just exactly cascading's FlowDef with scala Map/Vector/List? Then have functions to copy between? We could have a Monoid of this class to handle the merging.
3. Be on the lookout for any way to make this change smaller, while keeping the TypedPipe immutable. Verify that despite the fact that FlowDefs are mutable, the TypedPipe is still immutable.
4. Can we move the snapshot/save/toIterator/dump methods from the repl directly on to TypedPipe?