Unvanquished/Unvanquished — pull request #345 by slipher (2014-07-11 21:58:13+00:00)
Title: Fix mara zap dynamic light bug (?)

Remove some old unused mara zap code. Ignore an entity's constantLight f.ield if it is not ET_MOVER or ET_MODELDOOR as these are the only types that the server-side code creates a constant light in. For the mara, constantLight is used to store entity nums which erroneously caused a dynamic light to be created on each zap.

I believe it is actually a bug that the mara created any dynamic light when zapping. The reason this happens is because 3 entitynums are packed into the constantLight field. Often they are all ENTITYNUM_NONE which just happens to result in a moderately bright white light which looks quite reasonable as if it might have been designed that way on purpose.

It looks like the constantlight field is only supposed to be used for a couple of map elements so I added a line that ignores it if it isn't one of these. Hopefully this will prevent any dretch lamps.