turingschool/ruby-submissions — pull request #47 by objectParadigm (2014-07-10 17:18:00+00:00)
Title: peer review for Gu and Jess

Functional Expectations
===========================

rake broken tests
++++++++++++++++++++++

no_attribute_error_test

- wrong # of args
Merchant is getting instantiated w/o a repo wich bows up

- invalid date error? 4/35/2034
weird date in the far off future - we can't understand why you would supply this.

sanitation:all - 0 warnings GOOD JOB GUYS! :D

test-harness
++++++++++++++++++++++
takes a phenominally long ammount of time to execute and it varries: 8.5 minutes and then 5.25 minutes a second time?

Invoice - Creating New Invoices & Related Objects
two failing tests
- new invoice
- charge creates new transaction

Test-Driven Development
===============================
8 of 12 testing files are completely blank
tests make use of assert instead of assert_equal - gives several false positives

Encapsulation / Breaking Logic into Components
==================================================
Classes are broken out into logical components, methods look like they are reasonbly sized.
Several completely empty files within lib and test could be cleaned up or eliminated.

Fundamental Ruby & Style
==============================
makes good use of syntax, and methods are not overly verbose. Some refactoring could be done, but there arn't signifigant red flags.

Enumerable & Collections
===============================
find and find all by looks like it's just copy/paste of same method that is very unclear and looks like it needs serious refactoring. There are ZERO tests to help us understand the thought process which was pretty frustrating. Overall usage of enums looks decent though.

Code Sanitation
===================
zero errors - GOOD JOB! :D