puppetlabs/puppetlabs-mcollective — pull request #161 by jantman (2014-07-09 11:17:14+00:00)
Title: Modules 1192 - rename facts param on actionpolicy::rule to remove conflict with $facts hash

The gist of MODULES-1192 is that ``trusted_node_data=true`` is now (3.6) a "recommended and safe" puppet config setting; this enables the ``$facts`` hash, which makes ``$facts`` a reserved variable and therefore ``mcollective::actionpolicy::rule`` generates a compile-time failure.

This branch will probably need some fixup by me, but I've included my intermediate work in order to fully test and convey what I've done:
* pull in puppetlabs_spec_helper from master, to include not-yet-released https://github.com/puppetlabs/puppetlabs_spec_helper/pull/70 which lets us configure ``trusted_node_data``
* add missing test environments for 3.5.0 and 3.6.0 with strict_variables set to true; also add 3.6.0 test environments with future parser, and with future parser and trusted_node_data (the latter being the one of relevance to this ticket). IMO, we should keep the first and last of these - 3.5.0 with strict variables set, and 3.6.0 with both future parser and trusted_node_data, the latter being the most future-proof at the moment (as far as I know)
* add spec tests for the ``mcollective::actionpolicy::rule`` define, which was previously untested. Add one that uses the facts parameter.
* rename the param on ``mcollective::actionpolicy::rule`` from "facts" to "fact_filter" (this is the actual MODULES-1192 work). I've updated the README appropriately for the new param, but I'm not sure what the correct place is to document essentially a breaking change (side note on this - as I mentioned in the Jira ticket, I was unable to find a single piece of public code that uses this param).