rodjek/rspec-puppet — pull request #212 by jantman (2014-07-09 02:14:28+00:00)
Title: Add support for puppet3.6 config options trusted_node_data, ordering, st...

...ringify_facts

This effectively follows up on https://github.com/rodjek/rspec-puppet/pull/183 and the not-yet-merged https://github.com/rodjek/rspec-puppet/pull/209 by adding support for the rest of the parser-altering settings added in 3.6, specifically the three listed as "recommended and safe" (http://docs.puppetlabs.com/puppet/3.6/reference/config_important_settings.html#getting-new-features-early). ``ordering`` could prove quite useful, but the important part here is ``trusted_node_data`` which actually introduces two reserved variables, ``$facts`` and ``$trusted`` (see http://docs.puppetlabs.com/puppet/latest/reference/lang_facts_and_builtin_vars.html). This will prove valuable for modules (perhaps it should even be set to true by default?), since as it stands now, puppet4 will introduce these variables and likely break any modules that happen to use them.