burnbright/silverstripe-shop — pull request #267 by chillu (2014-07-09 06:23:24+00:00)
Title: Set Order->Paid date alongside Order->Status consistently

I've mistakenly pushed an unfinished commit to upstream/master rather than origin/master two days ago, which broke the shop builds (see https://travis-ci.org/burnbright/silverstripe-shop/builds/29288119 and http://take.ms/g3rej). I've since removed that commit from upstream by force pushing the previous revision. Sorry about that!

What do you think of the usage of PHPUnit mocks? I much prefer the https://github.com/padraic/mockery syntax, PHPUnit's is very counter intuitive. But its built-in, and does the job here - means I need to make assumptions about a limited amount of internal behaviour on the object (e.g. setting `TotalOutstanding` manually), but it keeps cause and effect relatively close to each other, only one level deep into the tested code. And don't need to build up massive state just to test one isolated feature like setting the paid date.