brianchandotcom/liferay-portal — pull request #19720 by sammso (2014-07-07 19:21:47+00:00)
Title: LPS-47231:DM is showing "Delete" button instead of "Move to Recycle bin"...

Hi @brianchandotcom,

/CC @natecavanaugh

I got this review request from @hhuijser and as I have created the issue it and being part of commenting earlier pull request. It did found it's way back to me again.

As I see this fix is good and @daviddotzhang did comment that he has tested all the use cases including CMIS connection. I give trust on him.

I see this is valid since used JavaScript operator is === and the value should be String as original themeDisplay.getScopeGroupId(); returns also String and this seems to be pattern on our JavaScript side.

It is always better to use === instead of ==.

Cheers, Sampsa