mdrewt/Connect4Friends — pull request #9 by adriansoghoian (2014-07-07 18:52:26+00:00)
Title: Code review

Hey @openspectrum, here's our project's code for review (FYI master is fully updated and is the one to review).

A few areas to draw your attention to:

+ Our JS file is enormous :) Would you recommend breaking up? If so, how? Perhaps mapping to our controllers or models (e.g. game, chat)?
+ I tried to add OO structure to chat by creating a Conversation constructor. Not that much logic is contained there though; in general how would you recommend we refactor our client logic to be more modular?
+ Any other feedback would be greatly welcomed!

Thanks!

PS. The JS for the Google Data Viz isn't rendering, but it's a known (and solveable) issue we'll tackle soon ;)

PPS. A general apology for the state of the code. Please be gentle.