shuyangzhou/liferay-portal — pull request #601 by akosthurzo (2014-07-04 14:03:10+00:00)
Title: [TECH SUPPORT] LPS-48282 Upgrade Tuckey urlrewrite from 2.6.0 to 4.0.3

Hi Shuyang,

There was a comment for this library saying "Do not upgrade to 3.2.0 since it degrades total performance by 25-50%". Therefore I made a performance test using the different Tuckey versions. For testing purposes I added more than 1500 redirect rule (in urlrewrite.xml) to have some data to compare. Basically I just added a Servlet Filter before and after URL Rewrite Filter to see how much time it takes to run. It was not the most precise method, but I think good enough to see the magnitude of the runtime differences.

Version | No extra rule | 1500+ extra rules
-----|--------|------------
2.6.0 | 20-50 ms | 10000-30000 ms
3.2.0 | 1 ms | 40-100 ms
4.0.3 | 1 ms | 40-200 ms

Based on the result from performance perspective it seems to be ok to upgrade, but Brian's comment on LPS-12463 made me a bit uncertain because I don't know what he exactly meant by total performance and how it was measured.

Please review the changes.

Thanks,
Ákos