l1j/en — pull request #175 by tricid (2014-07-04 23:40:12+00:00)
Title: Bonecp

This branch removes c3p0 and replaced it with bonecp. I also removed our custom leakcheckedconnections class because it shouldn't be necessary to be that paranoid anymore (I think this came from jp2). Imo our SQLUtil class should also be removed, it's pretty...redundant.

This fixes the db connectivity issues some of us get (or does for me so far), with some added options to retry transactions in a link failure. Meaning, in theory, you can completely reboot the mysql server while the game server is still running and this lib will keep trying to reconnect, then replay all missed transactions once it does.

The only downside are 2 additional dependencies, a logger framework and guava. If this makes it to master I suggest we go ahead and use the logger lib for everything, for consistency, even though I'm not a fan of additional libraries.

Do not pull until more people have tested. It seems to work fine for me.