OpenRA/OpenRA — pull request #5806 by Mailaender (2014-07-03 11:04:22+00:00)
Title: Fixed SeedsResources messing with make animation

This fixes #5300, but actually it does a lot more than that.

* The split of WithActiveAnimation from SeedsResource removes the rendering related stuff from logic Tick to TickRender like https://github.com/OpenRA/OpenRA/pull/5640 does for all other traits that did not hide their rendering abilities from me. It also removes the need to define fake active animations that are identical to idle (RA mines). It also gets feature parity with our recent building render traits such as allowing to disable it when it is on low power.

* I also found SeedsResources doing multiple expensive trait lookups every few ticks. This caches everything in the constructor to further improve performance.