kite-sdk/kite — pull request #132 by rdblue (2014-07-03 05:36:32+00:00)
Title: CDK-332: Deprecate DatasetReader#open and DatasetWriter#open.

This deprecates the reader and writer open methods so that users know
not to use them the design of the readers and writers remains the same,
with an initialization step. But, the initialization is done in an SPI
method, initialize, that is called after the reader or writer is
constructed, but before it is returned from newReader or newWriter.

The code has been moved to the new method by adding open to the
AbstractDatasetReader and a new AbstractDatasetWriter that logs a
warning that the call is no longer required. Tests that called log have
been migrated by either replacing the open call with a call to
initialize, or by removing the call to open. The first case is used
whenever the test instantiates the reader (or writer) itself, as in
TestCSVFileReader, and the latter is used when the reader comes from a
dataset or view.

Some helper methods expected an unopened reader either from newReader or
instantiated directly. These methods now check if the reader is open
and will call initialize if needed.