gsliepen/tinc — pull request #27 by dechamps (2014-06-29 09:03:58+00:00)
Title: Implement sptps_verify_datagram()

Implementation of `sptps_verify_datagram()` was left as a TODO. This causes problems when using SPTPS in tinc, because this function is used in `try_mac()`, which itself is used in `try_harder()` to locate nodes sending UDP packets from unexpected addresses. In the current state this function always returns `true`, resulting in UDP addresses of random nodes getting changed which makes UDP communication fragile and unreliable. In addition, this makes UDP communication impossible through port translation and local discovery.

This commit adds the missing implementation, thus fixing the issue.