tidepool-org/blip — pull request #94 by jebeck (2014-06-29 23:29:23+00:00)
Title: patientdata reorganization (improve tideline integration)

**NB**: Still a WIP, but I believe it is 100% functional, and the bulk of the work is done.

Depends on https://github.com/tidepool-org/tideline/pull/137

@jh-bate I didn't end up moving the messages stuff out of `patientdata.js`. I still think that could be desirable, but I'll leave it to you to think about, partially depending on where your upcoming work is going to live (i.e., in `patientdata.js` or in `app/components/mesages/`. `patientdata.js` is now slightly less than 400 lines from > 700, I believe, so it's already vastly more readable. \o/

@nicolashery some notes for you:
- Feel free to dictate naming. I know you have opinions on these things ;)
- Relatedly, I put all the chart components in one folder (`app/components/chart/`), but that's not exactly in line with your organization. I'd prefer to keep all the components together - I find the extreme proliferation of folders a little annoying, but, again, I'll let you be dictator.
- I like the React addons tool for managing classes, so I switched us to using the React with addons JS. LMK if there's some reason you were really avoiding that.
- I should probably refactor the empty header piece of `renderNoData` and `renderLoadingData`. Will do tomorrow probably...
- The `patientdata.less` is just being imported in `chart.less` because I think it might now be kind of difficult to untangle what belongs where (and the CSS for the Header component will be necessary in both places because `patientdata.js` requires header to render the (mostly) empty header as part of the renderNoData and renderLoadingData views...there could be a better way to organize this. Happy to discuss.

Probably forgetting a couple of notes, but this is enough to start with, I imagine :)