forrestv/p2pool — pull request #205 by CodeChief (2014-06-21 20:09:57+00:00)
Title: Correct namecoin default config filename and RPC port

There are a couple of inconsistencies between the namecoin defaults in "/bitcoin/networks.py" and the actual behaviour/code of namecoin (current version at least). First, the config file is called "namecoin.conf" not "bitcoin.conf". Second, the default RPC port is 8336 not 8332 which conflicts with bitcoin. Third, the test network entry for namecoin had the same port as the live bitcoin network, when it should actually be 18336.

Perhaps a really early version of namecoin really had those issues (same filename and RPC port as bitcoin) because I have seen a few questions about that, searching the internet. However if you look at the current namecoin code it is not the case. Either they have corrected them now or always had those unique values. So for the sake of avoiding future confusion and collision with bitcoin defaults, I believe this should be updated now.

This should be a low (perhaps zero) impact change because there is no direct namecoin support in P2Pool anyway, just via bitcoin merged mining. Further, when merged minding you provide the full RPC user, password and port via the "--merged" parameter. So these defaults are mainly for the record. I just want to make sure everything is correct to avoid confusion and make sure any new work we do in this area is with the right values.