geerlingguy/ansible-role-drupal — pull request #4 by allgood2386 (2014-06-20 16:28:56+00:00)
Title: Support for already created projects (modifications may be needed)

So a few things, first I'm new to ansible so best I'm not 100% up on best practices.

Second I've added a email address variable which has created a dependency (just need to apt-get sendmail in pretasks and it will run fine) but at some point I would envision that being something like mailcatcher to catch all mail coming from the vitualmachine/box (maybe a configuration flag? Again not sure what you can and can't do and what direction to head).

Other than that this appears to still work on my local machine but I'm not familiar with the travis ci process. Is there a testing bot that I should test this on? And should I work on updating the test coverage?

Finally I made some file mode permission changes. I changed files to 775 from 777 and added the group. I feel like adding the group will break rhel/centos variants and this may not be a needed change. I was having issues setting up a shared www folder with Vagrant so if these particular changes need to come out I can do that as well.

Let me know what you think, I realize this commit may be a bit of a mess, I'm still trying to figure out the best git submodule/ ansible galaxy workflow.