alphagov/whitehall — pull request #1567 by tekin (2014-06-18 14:06:30+00:00)
Title: Report exceptions raised during edition workflow

The fact that we are rescue these exceptions is a long-standing smell and a source of technical debt that we need to address. Work was started to extract all these workflow actions into self-contained and atomic
service objects such that we would no longer need to rescue these exceptions (see `EditionPublisher`, `EditionForcePublisher`, etc), but that work was not completed.

I propose we remove these `rescue_from` statements completely as they are masking all sorts of potential problems. Before we do, this change adds exception logging so that we can get a sense of the type and volume of exceptions we are currently silently handling. This will allow us to better asses the likely impact of removing them now instead of waiting until all workflow actions have had service objects extracted.