wmde/WikibaseQueryEngine — pull request #58 by thiemowmde (2014-06-18 08:43:02+00:00)
Title: Drop duplicated addMatchConditions code

I found the structure of this new code counterintuitive and confusing.
* All handlers implement `addMatchConditions`, but they are all exact copies.
* All these individual methods call `$this->addEqualityMatchConditions` which is a default implementation in the parent.

So why not just make `addMatchConditions` having a default implementation? It's still the exact same interface but avoids a lot of code duplication. Every handler is still free to override the default implementation as the LatLong and Time handlers already do.