FoundationDB/sql-layer — pull request #1333 by nathanlws (2014-06-16 21:15:33+00:00)
Title: Violations from concurrent DML fail DDL instead

As was discussed at some length a few meetings ago.

Key change being that when existing rows being checked for a new constraint, for example, any violation in concurrent DML will mark a key that is then inspected periodically by the DDL session. This is more consistent, easier to explain and removes an unnecessary serializable "side-step".

The only unexpected necessity was needing to prevent delayed constraint checking in the DML session. A flag to stop that seemed less invasive than calling back into OnlineHelper at commit time.

All disabled MTs are now enabled and passing, thanks to these changes and minor tweaks to the test helpers.