basho/riak_test — pull request #640 by kellymclaughlin (2014-06-13 21:19:06+00:00)
Title: replication_object_reformat test fails after riak_repl #590

This test relies on `repl_util:check_fullsync/3` that makes assumptions about the values of the `error_exits` and `retry_exits` stats after a fullsync is completed. The merge of https://github.com/basho/riak_repl/pull/590 affected these stats and they no longer match the expectation of the test. Here is the failure output from riak_test:

```
================ replication_object_reformat failure stack trace =====================
{{assertEqual_failed,[{module,repl_util},
{line,571},
{expression,"ErrorExits"},
{expected,0},
{value,4}]},
[{repl_util,'-check_fullsync/3-fun-3-',2,
[{file,"tests/repl_util.erl"},{line,571}]},
{repl_util,check_fullsync,3,[{file,"tests/repl_util.erl"},{line,571}]},
{repl_util,validate_completed_fullsync,6,
[{file,"tests/repl_util.erl"},{line,515}]},
{replication_object_reformat,verify_replication,5,
[{file,"tests/replication_object_reformat.erl"},
{line,116}]},
{replication_object_reformat,confirm,0,
[{file,"tests/replication_object_reformat.erl"},
{line,35}]},
{riak_test_runner,return_to_exit,3,
[{file,"src/riak_test_runner.erl"},{line,159}]}]}
======================================================================================
```

I modified the test to output the values for the `retry_exits` and `error_exits` stats reported before the test failed:

```
22:41:27.528 [info] Fullsync on 'dev1@127.0.0.1' complete
22:41:27.528 [info] Fullsync completed in 3.018526 seconds
22:41:27.529 [info] Retry exits: 0
22:41:27.529 [info] Error exits: 4
```

I am unsure if this is a just a case of the test expectations needing to be updated or if there is an actual problem here. I did verify that the test passes using the commit prior to the change commit from riak_repl #590.

cc: @cmeiklejohn