code-dot-org/blockly — pull request #674 by Bjvanminnen (2014-06-13 20:52:04+00:00)
Title: [Finishes #72746824] make direction turn after victory dance configurable

Some skins have a dance at the beginning of the level, and others don't. This makes it more explicit which are which. One of those marked as not having a dance (birds) previously scheduled the dance, but the DOM element doing the "dance" was hidden (replaced by the idle animation), such that it effectively had no dance.

My previous skin refactor checkin had actually made it so that no skins danced (something that I'm not entirely against, but is technically a regression =P). This fixes that.

When doing the dance after completing a level, in some cases we would run out of time to perform all of our animations, as the transparent tile step would start and would clear all existing timeouts. I made a design change to tell animateAction how long it has to perform an action. scheduleDance then uses this value to pack in all animations. Other action schedulers could also take advantage of this, though none do currently.