javihernandez/universal — pull request #4 by klown (2014-06-11 20:49:36+00:00)
Title: Device reporter draft2

Javi,

This addresses Bosmon's first comment, and goes a bit further to fix all the jshint issues in the device reporter JS files. Note that I only tested/fixed those JS files, not all of the JS files in "universal". That should be done too, but that's a separate issue.

I have a concern about a couple of the changes I made. I removed this line from DeviceGet.js, because jshint complained that kettle was defined but not used:
kettle = fluid.require("kettle", require);

Similarly, I removed the gpii variable from this line in DeviceReporter.js, since again jshint said gpii is defined but not used.
gpii = fluid.registerNamespace("gpii");

However, I left the call to fluid.registerNamespace("gpii") in the file in case it has needed side effects.

You should confirm those two changes are okay.

Thanks.