php/php-src — pull request #688 by mk-j (2014-06-09 19:25:23+00:00)
Title: Bug #67403 Add signatureType to openssl_x509_parse

Adding openssl signature parsing to openssl_x509_parse, so for instance, a cert with a sha1 signature should say sha1WithRSAEncryption (and not SHA1-With-RSA like other openssl signature functions might produce). There was some old commented out code, that didn't work. This pull request replaces it with working code.

Also removed unused const, DEFAULT_KEY_LENGTH in openssl, it was copied from req.c in the openssl examples source code, and is not otherwise used in php code. See how it was copied over from req.c (openssl source) when ext/openssl/openssl.c was first being written:
http://www.opensource.apple.com/source/OpenSSL098/OpenSSL098-32/src/apps/req.c?txt
(leaving it in is a bit misleading, because it appears to be a default key length, but actually defaults are controlled by openssl.cnf).