jejacks0n/navigasmic — pull request #42 by XA21X (2014-06-04 09:32:01+00:00)
Title: Paths (as hash) with different controllers but the same action name should not be highlighted?

The spec I wrote shows my interpretation of the expected behaviour of ```Item.highlights_on?```. This is how the method is used when the ```:highlights_on``` option has not been set when ```Navigasmic::Item.new``` is called with the link specified as a hash.

I do not know whether my interpretation is correct but in aefed7c where this behaviour was previously modified, the change in line 38 (hash matching using OR logic instead of AND) of _item.rb_ seems unnecessary for the implementation of the multi-controller feature (because they are in separate hashes).

I discovered this issue while I was using _navigasmic_ to generate links to _sign_in_ and _sign_up_ of the [Devise](https://github.com/plataformatec/devise) authentication gem. The link _sign_in_ would be highlighted even though I was on the _sign_up_ page.

Related to this, it seems like it would be useful in the future to add an optional parameter to ```semantic_navigation``` to specify the default behaviour of ```Item.highlights_on?``` so that for example, a navigation menu in the top bar could highlight on the same controller but a side menu would highlight only when the action also matches.