digitalbiblesociety/browserbible-3 — pull request #15 by anthonycrumley (2014-06-01 21:26:02+00:00)
Title: Fixed lemma popup disappearing.

John, I love what you are doing with this bible study site and would very much like to work with you on it. Please let me know if you would like some help.

I found this issue while using it and am proposing this change as a fix.

Thanks for the work you are doing here!!

Anthony

p.s. Following is a description of what I found and how I fixed it.

If the lemma popup was already displayed and a click happened elsewhere
on the document then the InfoWindow plugin would hide the lemma popup
which is proper behavior.

If the click happened on another lemma then the lemma popup would be
updated with new lemma information and moved to the new location by
the lemma plugin click handler. Then the click would bubble up to the
document click handler created InfoWindow and hide the updated lemma
popup. The result would be the appearance that the lemma popups had
quit working when in fact they were being displayed and immediately
hidden.

To correct this problem, the lemma popup is now hidden when ever it is
already visible and then redisplayed with the new lemma information.
This fixes the problem because the hide() function disables the document
click handler before the lemma click event bubbles up.