hdavid/Launchpad95 — pull request #3 by thomasf (2014-05-31 04:33:11+00:00)
Title: Project settings

Hello..

Very nice job man!
I think I want to start hacking on lp95 to try out a few ideas.

Here is a start for some config files to make it easier to work with for people using [flake8](https://pypi.python.org/pypi/flake8)-based tools. I've just set it to allow tabs for indentation since you use that, I've also added another file to tell emacs that tabs is the thing.

It is much easier to read consistently formatted code, especially when it comes to spacing rules..
How would you feel about if I fix most of the following things and make a pull request?
You seem to like tabs so let's keep them! If you have any

````
25 E101 indentation contains mixed spaces and tabs
1 E113 unexpected indentation
1 E121 continuation line under-indented for hanging indent
1 E124 closing bracket does not match visual indentation
70 E128 continuation line under-indented for visual indent
18 E201 whitespace after '['
24 E202 whitespace before ']'
20 E203 whitespace before ':'
76 E221 multiple spaces before operator
8 E222 multiple spaces after operator
1 E224 tab after operator
574 E225 missing whitespace around operator
48 E228 missing whitespace around modulo operator
1001 E231 missing whitespace after ','
53 E251 unexpected spaces around keyword / parameter equals
41 E261 at least two spaces before inline comment
37 E262 inline comment should start with '# '
234 E265 block comment should start with '# '
4 E271 multiple spaces after keyword
10 E272 multiple spaces before keyword
20 E302 expected 2 blank lines, found 1
77 E303 too many blank lines (2)
268 E501 line too long (83 > 79 characters)
2 E703 statement ends with a semicolon
372 E711 comparison to None should be 'if cond is not None:'
1 E712 comparison to True should be 'if cond is True:' or 'if cond:'
54 F401 'Live' imported but unused
17 F403 'from _Framework.ButtonElement import *' used; unable to detect undefined names
5 F811 redefinition of unused 'set_update_listener' from line 32
1 F812 list comprehension redefines 'k' from line 143
4 F841 local variable 'non_feedback_channel' is assigned to but never used
5863 W191 indentation contains tabs
122 W291 trailing whitespace
4 W292 no newline at end of file
462 W293 blank line contains whitespace
5 W391 blank line at end of file

````
Any of these rules can be disabled individually but some of them are quite helpful:

Especially warnings about mixed tabs and spaces since those can lead to real bugs

![launchpad95-whitespaces](https://cloud.githubusercontent.com/assets/330847/3138226/8b23c57a-e87a-11e3-9755-707d2855c013.png)