zmap/zmap — pull request #171 by MrPumo (2014-05-29 11:57:54+00:00)
Title: Improve monitor code with "probe module app_success" counter

Added a new global counter for "probe module app_success" evaluated at application level by probe module.

Probe module code should assert "app_success" field with "1" for VALID response regarding probe expected result. "0" otherwise.

ZMAP monitor code reports "probe_ok" unique success with avg and hits. (if probe module doesn't implement "app_success" field, monitor report for "probe_ok" same value of success field).

This patch can enable easier monitoring & debugging of probe module with APPLICATION check logic. I've find useful having double counter for probe module:

- one related to received pkt (that means a service is answering something in a response pkt...)

- one related to a valid application msg carried by pkt (ex..a valid dns response query, a valid chargen payload sequence, etc..).

With this patch ZMAP reports both in monitor and it helps investigating if invalid application msg (app_success=0) are due to wrong coded probe check or to refused application msg (ex.. a valid dns refused msg, etc...)

Regards,