acpica/acpica — pull request #34 by zetalog (2014-05-30 02:11:15+00:00)
Title: Tables: Add mechanism to control early table checksum verification.

The following regression is reported when the table length is very large:
WARNING: CPU: 0 PID: 0 at mm/early_ioremap.c:136 __early_ioremap+0x11f/0x1f2()
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted 3.15.0-rc1-00017-g86dfc6f3-dirty #298
Hardware name: Intel Corporation S2600CP/S2600CP, BIOS SE5C600.86B.99.99.x036.091920111209 09/19/2011
0000000000000009 ffffffff81b75c40 ffffffff817c627b 0000000000000000
ffffffff81b75c78 ffffffff81067b5d 000000000000007b 8000000000000563
00000000b96b20dc 0000000000000001 ffffffffff300e0c ffffffff81b75c88
Call Trace:
[] dump_stack+0x45/0x56
[] warn_slowpath_common+0x7d/0xa0
[] warn_slowpath_null+0x1a/0x20
[] __early_ioremap+0x11f/0x1f2
[] early_ioremap+0x13/0x15
[] __acpi_map_table+0x13/0x18
[] acpi_os_map_memory+0x26/0x14e
[] acpi_tb_acquire_table+0x42/0x70
[] acpi_tb_validate_table+0x27/0x37
[] acpi_tb_verify_table+0x22/0xd8
[] acpi_tb_install_non_fixed_table+0x60/0x1c9
[] acpi_tb_parse_root_table+0x218/0x26a
[] ? early_idt_handlers+0x120/0x120
[] acpi_initialize_tables+0x57/0x59
[] acpi_table_init+0x1b/0x99
[] acpi_boot_table_init+0x1e/0x85
[] setup_arch+0x99d/0xcc6
[] ? early_idt_handlers+0x120/0x120
[] start_kernel+0x8b/0x415
[] ? early_idt_handlers+0x120/0x120
[] x86_64_start_reservations+0x2a/0x2c
[] x86_64_start_kernel+0x13e/0x14d
---[ end trace 11ae599a1898f4e7 ]---
This is due to the size limitation of the x86 early IO mapping.
There is a large SSDT table on such platform that exceeds this limitation:
ACPI: SSDT 0x00000000B9638018 07A0C4 (v02 INTEL S2600CP 00004000 INTL 20100331)

It sounds strange that in the 64-bit virtual memory address space, we
cannot map a single ACPI table to do checksum verification. The root cause
is:
1. ACPICA doesn't split IO memory mapping and table mapping;
2. Linux x86 OSL implements AcpiOsMapMemory() using a size limited fix-map
mechanism during early boot stage, which is more suitable for only IO
mappings.

ACPICA originally only mapped table header for signature validation, and
this header mapping is required by OSL override mechanism. There was no
checksum verification because we could not map the whole table using this
OSL. While the following ACPICA commit enforces checksum verification by
mapping the whole table during Linux boot stage and it finally triggers
this issue on some platforms:
Commit: bf959821a98985b69b118ad6e6676a142c2e3241
Subject: Tables: Fix table checksums verification before installation.

Before doing further cleanups for the OSL table mapping and override
implementation, this patch introduces an option for such OSPMs to
temporarily discard the checksum verification feature. It then can be
re-enabled easily when the ACPICA and the underlying OSL is ready.

This patch also deletes a comment around the limitation of mappings because
it is not correct. The limitation is not how many times we can map in the
early stage, but the OSL mapping facility may not be suitable for mapping
the ACPI tables and thus may complain us the size limitation.

The AcpiTbVerifyTable() is renamed to AcpiTbVerifyTempTable() due to the
work around added, it now only applies to the table descriptor that hasn't
been installed and cannot be used in other cases. Lv Zheng.

Signed-off-by: Lv Zheng
Reported-and-tested-by: Yuanhan Liu