ealonso/liferay-portal — pull request #188 by lipusz (2014-05-28 10:23:47+00:00)
Title: [TECHNICAL-SUPPORT] LPS-46853 Additional commit to fix regression

https://issues.liferay.com/browse/LPS-46853

Hey Eudaldo,

A recent fix for LPS-46853 causes a regression on master. This is the final diff: https://github.com/liferay/liferay-portal/compare/95bfafd9b7...885e95560c

The regression is caused by liferay@c9d720d. It happens because BaseIndexer#addSearchLocalizedTerm assumes (incorrectly), that the searchContext already contains the localizedField as an attribute, but it may not. JournalArticleIndexer overrides this method, while ACI & AVI call the API in the BaseIndexer. Therefore, the localized fields don't get added to the searchQuery.

IMHO, this is a bug in the API, not in the logic of AVI/ACI#postProcessSearchQuery

Let me know if you have any concerns.

Regards,
Tibor