modxcms/revolution — pull request #11405 by Mark-H (2014-05-24 18:19:50+00:00)
Title: Bring back backwards compatibility for the help window.

In 2.2, overwriting MODx.config.help_url worked for loading a custom help url on CMPs. With this patch, that is once again possible. It prefers the new method (MODx.helpUrl, coming from the modManagerController.getHelpUrl() method) but checks the MODx.config.help_url for backwards compatibility.

It also prepends the base_help_url if the help url does not start with a protocol. Before this patch that was done on the server side (and stored in MODx.helpUrl), however that meant losing the ability to dynamically changing the help url in the manager. Putting that logic in the loadHelpPane method instead has the same result, but is more flexible.

**PS:** For some reason, all help buttons were removed in https://github.com/modxcms/revolution/commit/a84e038c7d26cf21094d075be523234ac42be72e - this seems a bit counterintuitive (why don't we want help buttons in the manager?) and I would suggest reverting that commit unless there's something I missed. @jpdevries