rapid7/metasploit-framework — pull request #3386 by todb-r7 (2014-05-23 20:53:02+00:00)
Title: Fix msftidy datastore errors

See the redmine bug:

https://dev.metasploit.com/redmine/issues/8498

This should knock out 9 msftidy errors, as detailed here:

https://docs.google.com/spreadsheets/d/1ODtJBZpReYFQqoGRqBw9YFqYt8_SEOLH01jrHTeM36U

This PR also proves that I wasn't lying when I opened #3380. Most of these aren't too terribly hard; in most cases, the module simply fails to use the existing API, and in most of those cases, it's because the API wasn't available at the time of writing of the module.

I took a look at `git blame` for all the fixes and noted who was the committer who landed the original datastore edit. This is not for public shaming, but because that person, I figure, is the one best able to eyeball my work and ensure that I'm not missing anything subtle in these modules. Given their respective module output volumes, I expect @wchen-r7 and @jvazquez-r7 to be implicated more often than not on this branch, and that's okay -- a changing API doesn't guarantee 3 year old modules are updated to use it.