chevah/compat — pull request #34 by adiroiban (2014-05-17 07:28:46+00:00)
Title: [#2149] Clean filesystem unit tests.

Problem
----------

there is a big of disorder in fs unit test

why we got this
---------------------

these are very old test and were the first test written for compat ... since then we got more experience

Changes
----------

For filesystem and setup spell checking I think that you should add those
works to your dictionary... there is no point in adding '-' just to make
a stupid spell checker happy.

We should not let our tools command us .. but just help :)

----------

The new testing.FileSystemTestCase has the same name as a tests.normal.test_filesystem.FileSystemTest case

--------

I have removed the impersonated unit tests since they were just mocking and I prefer to do non mocked test in elevated.

For fs unit test with default avatar, a class instance is used since the FS instance is
the same for the same avatar.

How to test
---------------

reviewers: @alibotean

check that changes are ok.

Note that many tests were just moved ... and not rewritten... this is why there might be bad practices in them.

Thanks!