DarkstarProject/darkstar — pull request #234 by starlightknight (2014-05-16 03:37:24+00:00)
Title: May Update: NPC ID Updates

Attempted batch update of NPC IDs with my batch job from #215. The new mapping file approach helped the job a lot in its verification, but it still struggles a lot with some of the more generic npc names (csnpc, blank, etc).

I will need to see what I can do to improve this approach further -- but we should also start standardizing on a naming convention. The lesser used zones (WoTG, etc) are all extremely inconsistent, and these areas are the hardest for automation right now because of it.

After the batch update I did some basic manual review of my own, but @gedads should probably eventually glance over it with his usual process. I specifically looked out for and fixed areas I knew the bad was weak at currently, and left the areas it seemed to be updating fine alone.

Covered the basics of - the file still loads, the server seems to work, and I did fix the start up warnings in conquest.lua and server.lua right off the bat as well this time.

Overall, there didn't seem to be nearly as many changes detected this time around as last time when the random achieve masters all over the place bumped almost all zones.

Hopefully that means less scripts to fix in the coming days, especially since we still haven't fixed all of them from the April update.