mozilla/rust — pull request #14191 by luqmana (2014-05-14 06:15:00+00:00)
Title: librustc: Make sure to add argument attributes to extern fns from non-local crates.

We were correctly determining the attributes needed for the parameters for extern fns, but when that extern fn was from another crate we never bothered to pass that information along to LLVM. (i.e never called `foreign::add_argument_attributes`).

I've just changed both local and non-local (crate) extern fn's to be dealt with together (through `foreign::register_foreign_item_fn`) so we don't run into something like again.

Fixes #14177.