TrinityCore/TrinityCore — pull request #12046 by phoenixfight (2014-05-10 14:16:46+00:00)
Title: [core/database]Repair fishing spell result fish escape

http://www.wowwiki.com/Fishing_items

As of 3.1, there is no longer a minimum skill requirement to fish in any zone, and all casts will catch something and award a chance for a skill-up. However, if your skill level is too low for a zone, you will catch mostly junk items. The skill level required to guarantee "no junk" catches is equivalent to the old "no get away" level.

I fix this in core codes,but there some question

1. the drop rate of junk item ,I have no idea. it maybe need change
2. there only use defaultzone :1 ,maybe Need to set a different drop rate in other zone,my scripts support do that.
3. I set some core defined value ,it maybe hack, if it is ,sorry about that.
my define is
```
SharedDefines.h : LOOT_MODE_JUNK_FISH = 0x8000
LootMgr.h :LOOT_FISHING_JUNK = 22
new function in GameObject: void getFishLootJunk(Loot* loot, Player* loot_owner);
```

sql:
```sql
-- set FISH_JUNK_GROUP = 11799;
-- set FISH_JUNK_LOOTMODE = 32768;
DELETE FROM fishing_loot_template WHERE `item`=11799;
INSERT INTO fishing_loot_template
(`entry`,`item`,`ChanceOrQuestChance`,`lootmode`,`groupid`,`mincountOrRef`,`maxcount`)
VALUES
('1','11799','100','32768','1','-11799','1');

DELETE FROM reference_loot_template WHERE `entry` = '11799';
INSERT INTO reference_loot_template
(`entry`,`item`,`ChanceOrQuestChance`,`lootmode`,`groupid`,`mincountOrRef`,`maxcount`)
VALUES
('11799','45190','15','32768','1','1','1'), -- [Driftwood]
('11799','45191','2','32768','1','1','1'), -- [Water Snail]
('11799','45194','15','32768','1','1','1'), -- [Tangled Fishing Line]
('11799','45195','5','32768','1','1','1'), -- [Empty Rum Bottle]
('11799','45196','15','32768','1','1','1'), -- [Tattered Cloth]
('11799','45197','5','32768','1','1','1'), -- [Tree Branch]
('11799','45198','15','32768','1','1','1'), -- [Weeds]
('11799','45199','5','32768','1','1','1'), -- [Old Boot]
('11799','45200','15','32768','1','1','1'), -- [Sickly Fish]
('11799','45201','3','32768','1','1','1'), -- [Rock]
('11799','45202','5','32768','1','1','1'); -- [Water Snail]
```

https://github.com/TrinityCore/TrinityCore/issues/12026