twbs/bootstrap — pull request #13541 by gpakosz (2014-05-08 22:27:03+00:00)
Title: Fixed affix-bottom positioning

Hello,

I'm a first time Bootstrap user so please forgive me if I overlooked something obvious.

When playing with an affixed sidebar, I noticed the sidebar could overlap my footer depending on the speed at which I scroll the page.

I also noticed that when I open Chrome dev tools and I make the dev tools panel take most of the height of the page, then refreshing the page would style my sidebar with `.affix-bottom` straight and also make it overlap my footer.

This is caused by `this.$element.offset({ top: position.top })` which positions the affixed element depending on its current position which only works if you transition smoothly from `.affix` to `.affix-bottom`.

I suggest this line gets replaced with `this.$element.offset({ top: scrollHeight - this.$element.height() - offsetBottom })` which corresponds to the computation made to decide whether or not to switch to `.affix-bottom` state.

What do you think?