mozilla/rust — pull request #14014 by pnkfelix (2014-05-07 11:59:30+00:00)
Title: Fix `make check-stage2` by fixing deps of exported syntax cfail tests.

Our `make check-stageN` for all N (including N=2) was not working,
because there is an unspecified dependence from the cfail tests on
certain crates that export syntax.

We need to encode that dependence in some manner. The quick hack is
to add `$$(CSREQ$(1)_T_$(3)_H_$(3)) $$(SREQ$(1)_T_$(2)_H_$(3))` to the
dependency list for *all* of the cfail tests. But I would prefer to
not force the make logic to build all of the external crates before it
gets to exercise the cfail tests.

So, here is how this PR fixes the problem more properly:

* Add `CTEST_DEPS_cfail-full` that, analogous to
`CTEST_DEPS_rpass-full`, has a dependency on
`$$(CSREQ$(1)_T_$(3)_H_$(3)) $$(SREQ$(1)_T_$(2)_H_$(3))`.
`CTEST_DEPS_cfail` is left unchanged (and thus continues to
match the structure of `CTEST_DEPS_rpass`).

* Added all of the other ingredients for `cfail-full` family of make
logic.

* moved cfail tests that rely on macros in separate crates to
separate compile-fail-fulldeps/ directory.

----

(Landing this may or not be a prerequisite for landing PR #14000. In
any case, this is a pretty isolated change and a net improvement in
the overall structure for the tests, IMO, at least given what we
currently have in the makefiles.)