abarisain/dmix — pull request #543 by avuton (2014-05-05 23:17:27+00:00)
Title: Warning fixes, NowPlaying*Fragment cleanups, Persistent Notification, Precompiled Patterns, App singleton...

Wow, writing the title, I'm starting to realize there's a ton of stuff here, the title didn't do it all justice. Anyhow, seems stable enough here to the point that I need to get this "out there" for testing.

I did rewrite some newly written code (as we discussed) simply for cleanliness. I dropped the streaming patches (due to the new StreamFragment stuff) and I've pushed some of the patches we discussed until later.

The NowPlaying*Fragment stuff should be really good (I hope). No more seekbar jumping around when seeking (I /hope/), or at least less of it, it's been cleaned up and is now dynamic.

Persistent notification stuff has been around for some time, but I didn't get serious about it until @DrVanScott drowned me with issues with notifications in general. The persistent notification patch is actually quite a refactoring of notification support (1.1? ;)) rather than just persistent notification support.

The app singleton allowed a huge cleanup and, while I got a lot of it, I'm sure there are odds and ends from here.

Warning fixes, JMPDComm reformatting (oy did it need it), Music / MPDStatistics / Miscellaneous refactoring, tons of possible (unfound?) bug fixes, StreamingService possible crash fix under bad conditions... and more things I'm sure I forgot already.

I'll try to push more early and often. I get started... and it's hard to stop. Taking time off to review patches is boring (why most devs don't even do it!), but I don't want to PR prior to that and I let this party carry on a little too long (sorry!).