boxen/puppet-vagrant — pull request #43 by tarebyte (2014-05-03 15:12:10+00:00)
Title: WIP Updating to vagrant 1.5.4, and fixing failing Specs

I wanted to update vagrant to the latest version. When I ran script/cibuild I was getting an dependencies error. So I updated boxen, and added stdlib because `validate_strings` wasn't working.

I'm still running into this issue

```
Failures:

1) vagrant::box::vmware::lenny64
Failure/Error: should contain_vagrant__box('lenny64/vmware_fusion').
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/classes/vagrant__box__vmware__lenny64_spec.rb:7:in `block (2 levels) in '

2) vagrant::box::vmware::precise64
Failure/Error: should contain_vagrant__box('precise64/vmware_fusion').
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/classes/vagrant__box__vmware__precise64_spec.rb:7:in `block (2 levels) in '

3) vagrant::box::vmware::squeeze64
Failure/Error: should contain_vagrant__box('squeeze64/vmware_fusion').
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/classes/vagrant__box__vmware__squeeze64_spec.rb:7:in `block (2 levels) in '

4) vagrant::box::vmware::wheezy64
Failure/Error: should contain_vagrant__box('wheezy64/vmware_fusion').
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/classes/vagrant__box__vmware__wheezy64_spec.rb:7:in `block (2 levels) in '

5) vagrant::box
Failure/Error: should include_class('vagrant')
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/defines/vagrant__box_spec.rb:13:in `block (2 levels) in '

6) vagrant::box with ensure set to absent
Failure/Error: should contain_vagrant_box("squeeze64").with({
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/defines/vagrant__box_spec.rb:30:in `block (3 levels) in '

7) vagrant::plugin
Failure/Error: should include_class('vagrant')
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/defines/vagrant__plugin_spec.rb:8:in `block (2 levels) in '

8) vagrant::plugin name does not begin with vagrant-
Failure/Error: should contain_vagrant_plugin('vagrant-vmware-fusion')
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/defines/vagrant__plugin_spec.rb:18:in `block (3 levels) in '

9) vagrant::plugin with license
Failure/Error: should contain_file('/Users/testuser/.vagrant.d/license-vagrant-vmware-fusion.lic').with({
Puppet::Error:
Duplicate declaration: File[undef] is already declared in file /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51; cannot redeclare at /Users/mark/src/boxen/puppet-vagrant/spec/fixtures/modules/boxen/manifests/config.pp:51 on node markbookpro.gateway.2wire.net
# ./spec/fixtures/modules/boxen/lib/puppet/provider/package/hax.rb:13:in `benchmark'
# ./spec/defines/vagrant__plugin_spec.rb:32:in `block (3 levels) in '

Finished in 1.2 seconds
12 examples, 9 failures

Failed examples:

rspec ./spec/classes/vagrant__box__vmware__lenny64_spec.rb:6 # vagrant::box::vmware::lenny64
rspec ./spec/classes/vagrant__box__vmware__precise64_spec.rb:6 # vagrant::box::vmware::precise64
rspec ./spec/classes/vagrant__box__vmware__squeeze64_spec.rb:6 # vagrant::box::vmware::squeeze64
rspec ./spec/classes/vagrant__box__vmware__wheezy64_spec.rb:6 # vagrant::box::vmware::wheezy64
rspec ./spec/defines/vagrant__box_spec.rb:12 # vagrant::box
rspec ./spec/defines/vagrant__box_spec.rb:29 # vagrant::box with ensure set to absent
rspec ./spec/defines/vagrant__plugin_spec.rb:7 # vagrant::plugin
rspec ./spec/defines/vagrant__plugin_spec.rb:17 # vagrant::plugin name does not begin with vagrant-
rspec ./spec/defines/vagrant__plugin_spec.rb:31 # vagrant::plugin with license
```

I'm not entirely sure what those failing tests mean. Can anyone shed some light on this?