Shopify/active_merchant — pull request #1158 by odorcicd (2014-05-01 20:14:15+00:00)
Title: Remove greedy rescue, and convert some errors to be user-facing

@bslobodin @ntalbott
The rescue was too greedy on `ActionViewHelper#payment_service_for` for offsite Integrations.

This changes the behaviour so that errors that are user facing (bad credentials, invalid responses from remote calls, etc) will be raised as ActionViewHelperError, so they can potentially be rescued and displayed to the user. Any other errors should presumably be an implementation error (bad values passes in, wrong implementation within the helper, etc) and would continue to bubble up so a developer could address it.