edx/edx-platform — pull request #3533 by johncox-google (2014-04-30 00:51:58+00:00)
Title: Fix bug that prevented account association during registration

@nedbat: A tiny bugfix I'd like to merge tomorrow.

Previously, when resuming the pipeline in the register case, dispatch_to_login was True because user_inactive was True. dispatch_to_login may be True iff is_login is True; otherwise, during new account registration we'd redirect to /login rather than resuming the pipeline. This looked almost correct in the UI, but because the rest of the pipeline failed to execute, the association between the user's edX account and their third-party account was never created.

Also fixed buggy test that failed to catch this case.

@psimakov, @jbau, @jzoldak: Just FYI -- nothing for you to do.