driftyco/ionic-site — pull request #165 by ianlyons (2014-04-25 17:20:13+00:00)
Title: Update menuToggle documentation

Hi guys,

First, love your framework. I'm developing in it right now and am shocked at how quickly one can scaffold together an application.

Second, it seems that the way menu-toggle works right now is that it runs a $scope.$eval() on the content of the menu-toggle attribute, so it's expecting an angular expression. Leaving it just with double-quotes works for the left side-menu, but adding menu-toggle="right" actually toggles the right-hand side menu as well. menu-toggle="'right'" works as expected, as does menu-toggle="'left'".

I wasn't sure how much detail to put into the docs about this, but it seems like you don't delve a whole lot into the "why" in your other documentation, just the "how", so I went a little minimalist on my changes. Let me know if you'd prefer that I change something.

Thanks again for your work!
Ian