nizmox/demochat — pull request #1 by mathildathompson (2014-04-26 03:01:09+00:00)
Title: Project_2_feeback

Amazing project 2 Demochat team!!
So impressed you managed to build something this complex in such a short time!

I have added a few comments if you have a look at the files changed in the pull request. Do not merge the request, just thought it was the easiest way for you to look at changes.

Main points are using more partials. There are a couple of forms and a nav that could be refactored into partials. In your demochat.js file you have an event listener functions on both submit and keypress, they have exactly same code inside which is not DRY, refactor this into one function.

Throughout your javascript you are converting this to self. I know its makes more sense as it ties in nicely with Ruby, but I would try and use this as you are having to write a lot of extra lines of code and its not that readable.

There is some JS controlling the scroll inside script tags in the html, this should be in its own javascript file.

Finally and most importantly you MUST write tests! Tests will come into their own in this app as the backend is very complex.

Well done again guys, I will send you a link to the Rubric!