FasterXML/jackson-databind — pull request #445 by hhuether (2014-04-25 10:07:44+00:00)
Title: Consistent usage of deserialize(...) return values

The return value of JsonDeserializer.deserialize(...) not being used confused me.

Within my custom deserializer, I instantiated a new object (based on valueToUpdate) and returned it from the deserialize method, expecting it to become the deserialization result. But since the return value of the method is not used at all, that did not work, of course.

Wouldn't it be more intuitive and consistent to use the return value here instead of valueToUpdate as the deserialization result?

I might be missing something, since I'm just a user of jackson and do not have deeper knowledge of its code base, so if there were reasons to handle it like that which I don't know about... feel free to decline my pull request.

Thanks!