kiiadi/abc-bank — pull request #17 by stevelibonati (2014-04-24 23:14:28+00:00)
Title: abc-bank pull request

Bunch of changes ...

- removed commented out code
- removed test methods marked @Ignore
- changed visibility of instance members , created getters setters where appropriate
- refactored Accounts to OO with inheritance
- added transfer feature
- added maxiSavingsAccount feature
- added extensive unit testing
- added some pretty raw code to build accrual table for last feature;
- refactored the whole project to use BigDecimal as a datatype for amounts in place of doubles
- BigDecimal refactoring necessitated NumberFormat for printing report ; used Currency class
- added synchronization as appropriate
- refactored string concatenation

probably more I don't recall :-)

given more time I would have completed:

- the daily interest accrual feature
- additional unit tests
- corrected visibility on many methods and changed units appropriately; i.e. many methods were left public where they should have been private and the units could have been refactored to test using reflection API
- general cleanup , commenting ...