pcbsd/pcbsd — pull request #34 by panzi (2014-04-25 02:30:41+00:00)
Title: fix potential buffer overflow in SYSTEM::hostname

gethostname() may cause an error or it might need more space than any given static buffer provides. In both cases the data in the buffer might not be null terminated!

Also String() uses fromAscii(). While I guess this should be ok for host names I think it is always better to use fromLocal8Bit(). I think the user name might not be 7-bit ASCII.

**Note:** I wrote this from head in the online editor on GitHub. So I haven't even tested if it compiles. I just wanted to tell you about that possible problem.