github/hubot-scripts — pull request #1423 by ellisju (2014-04-23 22:35:35+00:00)
Title: Fixes earlier attempt to add the functionality to work with additional jsdom versions

Fixes what was attempted with commit 5f8a7bd7b9881307dd6c428106d597af68aebb83. The problem with that code is that it is comparing two strings as if they are numbers, which does not work. For instance, if your jsdom.version is '0.10.1' then it will evaluate in the code as 'less than' '0.7.0', make an incorrect call to jsdom.env and nothing will work. I've added a quick and dirty, basic function to compare version number strings. It can certainly be improved upon, but should work well enough.