cms-sw/cmssw — pull request #3423 by Sam-Harper (2014-04-22 12:59:49+00:00)
Title: Trigger photon fix

The HLTPMMassFilter needs protection against objects being of type TriggerPhoton rather than type TriggerCluster for upcoming HLT menus and needs to go in. I also took the opportunity to protect the remaining E/gamma filters which were unprotected against this.

Explanation of the issue:
Due to a rather poor design decision made before my time (yes its really that old), E/gamma trigger objects use TriggerClusters for non-saved RecoEcalCandidates and TriggerPhotons for saved RecoEcalCandidates. You need to look for both as there is no way to know for sure which the previous filter will output as it depends on whether saveTags=true for the previous filter. We probably should have fixed this at the source (and say this every time the issue comes up) but I'm concerned a core change in the framework will need a lot of testing for edge cases as it is not obvious everywhere this is used. Just checking for both is an accepted solution that has been running fine for all of data taking. It is very clear when this bug comes in as the filter will accept zero events.